-
-
Notifications
You must be signed in to change notification settings - Fork 365
Implement auto font scaling and update docs #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
questions and changes
|
Changes made. I remove the note on |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2623 +/- ##
==========================================
+ Coverage 96.53% 96.63% +0.09%
==========================================
Files 141 152 +11
Lines 12535 13137 +602
==========================================
+ Hits 12101 12695 +594
- Misses 434 442 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me, but I defer to @Meakk
|
You are modifying libf3d public API! |
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there, just a doc changes needed :)
|
\ci full |
|
you need to rebase on master |
aa3f0e8 to
22818bd
Compare
|
|
||
| Set the _window resolution_. | ||
|
|
||
| ### `--dpi-scale (_bool_, default: `false`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### `--dpi-scale (_bool_, default: `false`) | |
| ### `--dpi-scale` (_bool_, default: `false`) |
Describe your changes
vtkF3DRenderer.cxxundervtkF3DRenderer::ConfigureTextActors()new_release.md03-OPTIONS.mdIssue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
CI not testable