Skip to content

Conversation

@mwestphal
Copy link
Member

@mwestphal mwestphal commented Dec 19, 2025

Describe your changes

  • Add Stream support to vtkF3DOCCTReader
  • Add proper error handling
  • Add test and error tests

Issue ticket number and link if any

Related to #1100

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@mwestphal mwestphal marked this pull request as ready for review December 21, 2025 17:54
@mwestphal
Copy link
Member Author

\ci full

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

You are modifying versions.json, please update the docker timestamp as well, this will generate new docker images and caches needed for CI.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.64%. Comparing base (98db5a5) to head (3dc4457).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2726      +/-   ##
==========================================
+ Coverage   96.61%   96.64%   +0.02%     
==========================================
  Files         142      142              
  Lines       12730    12768      +38     
==========================================
+ Hits        12299    12339      +40     
+ Misses        431      429       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal requested review from Meakk and snoyer December 23, 2025 13:18
@mwestphal mwestphal changed the title Occt stream Add stream support to vtkF3DOCCTReader Dec 23, 2025
@mwestphal mwestphal requested a review from Meakk December 23, 2025 15:31
@mwestphal mwestphal self-assigned this Dec 23, 2025
Copy link
Contributor

@snoyer snoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because the tests work and the lack of IGES is justified but I'm not competent to judge the VTK/C++ implementation details

@mwestphal mwestphal merged commit a736307 into f3d-app:master Dec 26, 2025
78 checks passed
vincenzonetti pushed a commit to vincenzonetti/f3d that referenced this pull request Dec 26, 2025
    Add Stream support to vtkF3DOCCTReader
    Add proper error handling
    Add test and error tests
atharvRsharma pushed a commit to atharvRsharma/f3d that referenced this pull request Jan 8, 2026
    Add Stream support to vtkF3DOCCTReader
    Add proper error handling
    Add test and error tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants