Add stream support to vtkF3DOCCTReader#2726
Merged
mwestphal merged 18 commits intof3d-app:masterfrom Dec 26, 2025
Merged
Conversation
42 tasks
Member
Author
|
\ci full |
6abb2a8 to
5264597
Compare
|
You are modifying versions.json, please update the docker timestamp as well, this will generate new docker images and caches needed for CI. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2726 +/- ##
==========================================
+ Coverage 96.61% 96.64% +0.02%
==========================================
Files 142 142
Lines 12730 12768 +38
==========================================
+ Hits 12299 12339 +40
+ Misses 431 429 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7b22fc0 to
6ac9e30
Compare
mwestphal
commented
Dec 23, 2025
Meakk
reviewed
Dec 23, 2025
Meakk
approved these changes
Dec 23, 2025
snoyer
reviewed
Dec 26, 2025
snoyer
approved these changes
Dec 26, 2025
Contributor
snoyer
left a comment
There was a problem hiding this comment.
Approving because the tests work and the lack of IGES is justified but I'm not competent to judge the VTK/C++ implementation details
vincenzonetti
pushed a commit
to vincenzonetti/f3d
that referenced
this pull request
Dec 26, 2025
Add Stream support to vtkF3DOCCTReader
Add proper error handling
Add test and error tests
atharvRsharma
pushed a commit
to atharvRsharma/f3d
that referenced
this pull request
Jan 8, 2026
Add Stream support to vtkF3DOCCTReader
Add proper error handling
Add test and error tests
vincenzonetti
pushed a commit
to vincenzonetti/f3d
that referenced
this pull request
Feb 8, 2026
Add Stream support to vtkF3DOCCTReader
Add proper error handling
Add test and error tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link if any
Related to #1100
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.