-
-
Notifications
You must be signed in to change notification settings - Fork 365
Add stream support to vtkF3DOCCTReader #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
\ci full |
6abb2a8 to
5264597
Compare
|
You are modifying versions.json, please update the docker timestamp as well, this will generate new docker images and caches needed for CI. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2726 +/- ##
==========================================
+ Coverage 96.61% 96.64% +0.02%
==========================================
Files 142 142
Lines 12730 12768 +38
==========================================
+ Hits 12299 12339 +40
+ Misses 431 429 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7b22fc0 to
6ac9e30
Compare
snoyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because the tests work and the lack of IGES is justified but I'm not competent to judge the VTK/C++ implementation details
Add Stream support to vtkF3DOCCTReader
Add proper error handling
Add test and error tests
Add Stream support to vtkF3DOCCTReader
Add proper error handling
Add test and error tests
Describe your changes
Issue ticket number and link if any
Related to #1100
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.