Added time as a uniform property for final shader#2793
Closed
RealEdwardS wants to merge 0 commit intof3d-app:masterfrom
Closed
Added time as a uniform property for final shader#2793RealEdwardS wants to merge 0 commit intof3d-app:masterfrom
RealEdwardS wants to merge 0 commit intof3d-app:masterfrom
Conversation
mwestphal
reviewed
Jan 8, 2026
AoGao-Kedoka
reviewed
Jan 8, 2026
Member
|
Nice straightforward implementation :) |
Member
|
Need any help moving forward @RealEdwardS ? |
Author
yes I do, sorry for not being active; i'll post a follow up on discord in a few days, but i'm still going to work on it. |
Member
|
@RealEdwardS please do not merge with master, instead rebase on master. |
|
You are modifying versions.json, please update the docker timestamp as well, this will generate new docker images and caches needed for CI. |
Member
|
Well, looks like it went wrong, do you need help with the rebase ? :) |
Member
|
still wrong, let me know :) |
Member
|
nope ^^ |
RealEdwardS
force-pushed
the
final-shader-improvements
branch
from
904d8b4 to
d76b176
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added time elapsed from the app start as a uniform property for final shader application.
time is stored as a double, however, there doesn't seem to be a
SetUniformfunction for doubles (according to the docs - https://vtk.org/doc/nightly/html/classvtkUniforms.html), so I'm usingSetUniformf.Issue ticket number and link if any
#2257
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.