Skip to content

Conversation

@AoGao-Kedoka
Copy link
Contributor

@AoGao-Kedoka AoGao-Kedoka commented Jan 8, 2026

Describe your changes

  • added--display-depth command line option

For greyscaled depth:
./bin/f3d --display-depth --multi-file-mode=all ../testing/data/multi

image

For color mapped depth:
./bin/f3d --display-depth --scalar-coloring --multi-file-mode=all ../testing/data/multi

image

Issue ticket number and link if any

#50

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@AoGao-Kedoka AoGao-Kedoka changed the title Display depth image#50 Display depth image #50 Jan 8, 2026
@AoGao-Kedoka AoGao-Kedoka changed the title Display depth image #50 Display depth image Jan 8, 2026
- Discard vtkF3DRenderPass when display depth is enabled to retried
depth texture
- Directly use depth map from geometry pass for displaying depth
greyscaled or colormapped
@AoGao-Kedoka
Copy link
Contributor Author

\ci full

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.67%. Comparing base (6930f0c) to head (f4c4653).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
+ Coverage   96.64%   96.67%   +0.03%     
==========================================
  Files         142      144       +2     
  Lines       12923    13045     +122     
==========================================
+ Hits        12489    12611     +122     
  Misses        434      434              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants