-
-
Notifications
You must be signed in to change notification settings - Fork 364
Display depth image #2795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AoGao-Kedoka
wants to merge
11
commits into
f3d-app:master
Choose a base branch
from
AoGao-Kedoka:display-depth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Display depth image #2795
+313
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meakk
requested changes
Jan 8, 2026
- Discard vtkF3DRenderPass when display depth is enabled to retried depth texture - Directly use depth map from geometry pass for displaying depth greyscaled or colormapped
Meakk
requested changes
Jan 9, 2026
Contributor
Author
|
\ci full |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2795 +/- ##
==========================================
+ Coverage 96.64% 96.67% +0.03%
==========================================
Files 142 144 +2
Lines 12923 13045 +122
==========================================
+ Hits 12489 12611 +122
Misses 434 434 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
--display-depthcommand line optionFor greyscaled depth:
./bin/f3d --display-depth --multi-file-mode=all ../testing/data/multiFor color mapped depth:
./bin/f3d --display-depth --scalar-coloring --multi-file-mode=all ../testing/data/multiIssue ticket number and link if any
#50
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.