[draft] Adding PDAL support

[mwestphal]

Describe your changes

• CI: Add tiff (fixed version for now)
• CI: Add sqlite (fixed version from csb)
• CI: Add proj (fixed version for now)
• CI: Add tiff (fixed version for now)
• CI: Add geotiff (fixed version for now)
• CI: Add gdal (fixed version for now)
• CI: Add curl (fixed version for now)
• CI: Add pdal (fixed version for now)
• CI: Enable all deps in VTK dependencies and VTK
• Add a simple pdal plugin F3D

TODO:

• Proper F3DPDALImpl
• Add all formats
• Check sanitizer issue
• Check minver
• Superbuild update and pdal stack move
• Android and wasm ? is it needed ? no stream support for now
• Stream support ?

               ┌──────┐    
               │ VTK  │    
               └──┬───┘    
                  │        
        ┌─────────┴───┐    
        │        PDAL │    
        └─┬─┬─────┬──┬┘    
    ┌─────┘ │     │  └──┐  
┌───┴───┐   │  ┌──┴───┐ │  
│ CURL  │   │  │ GDAL │ │  
└───────┘   │  └┬┬┬───┘ │  
   ┌────────┘   │││     │  
   │   ┌────────┘││     │  
   │   │         ││     │  
┌──┴───┴──┐      ││     │  
│ GEOTIFF │      ││     │  
└─┬───┬─┬─┘      ││     │  
  │ ┌─┼─┼────────┘│     │  
  │ │ │ └─────────┼───┐ │  
  │ │ └─────┐  ┌──┘   │ │  
 ┌┴─┴───┐  ┌┴──┴──┐   │ │  
 │ TIFF │  │ PROJ │   │ │  
 └───┬──┘  └───┬──┘   │ │  
     │         │      │ │  
     └─────────┼────┐ │ │  
        ┌──────┴─┐ ┌┴─┴─┴─┐
        │ SQLITE │ │ ZLIB │
        └────────┘ └──────┘

Issue ticket number and link if any

#201

Checklist for finalizing the PR

• I have performed a self-review of my code
• I have added tests for new features and bugfixes
• I have added documentation for new features
• If it is a modifying the libf3d API, I have updated bindings
• If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

[mwestphal]

\ci main

[codecov]

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.98%. Comparing base (f2141ac) to head (4c1714d).
⚠️ Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
plugins/pdal/module/vtkF3DPDALReader.cxx	90.90%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2907      +/-   ##
==========================================
- Coverage   97.00%   96.98%   -0.03%     
==========================================
  Files         204      206       +2     
  Lines       16219    16246      +27     
==========================================
+ Hits        15734    15756      +22     
- Misses        485      490       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mwestphal]

\ci full

[Meakk]

Just in case:

  graph TD;
      VTK-->PDAL;
      PDAL-->CURL;
      PDAL-->GEOTIFF;
      PDAL-->GDAL;
      PDAL-->ZLIB;
      GEOTIFF-->TIFF;
      GEOTIFF-->PROJ;
      GEOTIFF-->ZLIB;
      TIFF-->ZLIB;
      PROJ-->SQLITE;
      GDAL-->GEOTIFF;
      GDAL-->TIFF;
      GDAL-->PROJ;

Loading

[mwestphal]

Just in case:

  graph TD;
      VTK-->PDAL;
      PDAL-->CURL;
      PDAL-->GEOTIFF;
      PDAL-->GDAL;
      PDAL-->ZLIB;
      GEOTIFF-->TIFF;
      GEOTIFF-->PROJ;
      GEOTIFF-->ZLIB;
      TIFF-->ZLIB;
      PROJ-->SQLITE;
      GDAL-->GEOTIFF;
      GDAL-->TIFF;
      GDAL-->PROJ;

Loading

I had no idea mermaid was that easy ^^

[mwestphal]

misclick, sry.

[github-actions]

You are modifying versions.json, please update the docker timestamp as well, this will generate new docker images and caches needed for CI.

[github-actions]

Style Checks CI failed:

diff --git a/plugins/pdal/module/vtkF3DPDALReader.cxx b/plugins/pdal/module/vtkF3DPDALReader.cxx
index dee282b..67f0594 100644
--- a/plugins/pdal/module/vtkF3DPDALReader.cxx
+++ b/plugins/pdal/module/vtkF3DPDALReader.cxx
@@ -1,7 +1,7 @@
 #include "vtkF3DPDALReader.h"
 
-#include "vtkPointData.h"
 #include "vtkDoubleArray.h"
+#include "vtkPointData.h"
 
 #include <iostream>
 
@@ -26,8 +26,8 @@ int vtkF3DPDALReader::RequestData(
     vtkNew<vtkDoubleArray> normalizedColors;
     normalizedColors->SetNumberOfComponents(3);
     normalizedColors->SetName("NormalizedColor");
-    
-    // TODO PROPER API 
+
+    // TODO PROPER API
     double colorRanges[3][2];
     for (int j = 0; j < 3; j++)
     {
@@ -48,7 +48,7 @@ int vtkF3DPDALReader::RequestData(
       {
         normalized[j] = (color[j] - colorRanges[j][0]) / colorRanges[j][1];
       }
-      normalizedColors->InsertNextTuple(normalized); 
+      normalizedColors->InsertNextTuple(normalized);
     }
     pointData->AddArray(normalizedColors);
   }