Remis en place de la protection contre écriture sur BuildingHistory #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ady has unique rnb_id constraint
leonkenneth
reviewed
Jun 13, 2025
| # if model == BuildingWithHistory or model == BuildingHistoryOnly: | ||
| # raise Exception("BuildingWithHistory model is read only!") | ||
|
|
||
| if model == BuildingWithHistory or model == BuildingHistoryOnly: |
There was a problem hiding this comment.
J'imagine que BuildingWithHistory restait read-only car c'est une view?
Peut-être ajouter un DBRouter.DANGEROUSLY_ALLOW_UPDATE_BUILDING_HISTORY plutôt que commenter ?
Notamment ça permettrait de le désactiver dans la migration mais pas dans le reste du code le temps du déploiement. Si on en a eu besoin une fois, c'est possible qu'on en ait besoin de nouveau.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Le fix sur la PR638 imposait de débrancher un mécanisme de protection contre l'écriture dans la building_history.
Cette PR remet en place cette protection.
Elle ajoute également une contrainte d'unicité sur le couple rnb_id / event_id dans la table building_history.
Il est possible que la mise en place de cette contrainte bloque l'accès à la table pendant un long moment. Je vais tester sur staging avant de mettre en place sur prod.