feat: ISBN validation #1097
Open
feat: ISBN validation #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ysknsid25 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces ISBN validation functionality for the library management system, allowing the verification of both ISBN-10 and ISBN-13 formats when registering books. Key changes include adding new validation logic in the ISBN action, comprehensive test cases for the new functionality, and an update to the API menu to expose the ISBN endpoint.
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| library/src/actions/isbn/isbn.test-d.ts | Adds TypeScript type tests for ISBN action object |
| library/src/actions/isbn/isbn.test.ts | Provides tests for both valid and invalid ISBN datasets |
| library/src/actions/isbn/isbn.ts | Implements the ISBN validation and related documentation |
| library/src/actions/isbn/index.ts | Exports the ISBN action |
| website/src/routes/api/menu.md | Updates API menu to include the new ISBN endpoint |
Files not reviewed (3)
- website/src/routes/api/(actions)/isbn/index.mdx: Language not supported
- website/src/routes/api/(schemas)/string/index.mdx: Language not supported
- website/src/routes/guides/(main-concepts)/pipelines/index.mdx: Language not supported
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
a -> an Signed-off-by: ysknsid25 <[email protected]>
|
Great idea! Thank you for creating this PR! I will try to review it next week! |
commit: |
Signed-off-by: ysknsid25 <[email protected]>
|
Sorry for the delay. I will get back to this PR as soon as possible. |
|
no problem. take it easy 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a certified librarian. So I realized that I would like to be able to verify ISBNs when registering books.
The ISBN specifications are here.