Skip to content

Conversation

@TapuCosmo
Copy link
Contributor

Fixes #213. Multi Action now works without blocking Inkscape.

A call to a nonexistent function show_log_as_dialog was previously being made if unblock_inkscape was true, which caused Multi Action to fail when not blocking Inkscape. Removing this call allows Multi Action to work properly without blocking Inkscape.

@lex-neufeld
Copy link

@TapuCosmo What steps or test can reproduce the error? for #308

this function is in silhouette_multi.py on line 41

def show_log_as_dialog(parent=None):

It seems to be desired that a dialogue box of "Silhouette Multi Log" be shown anytime a background process for the Silhouette finishes, or anytime you try to close inkscape if any background processes are running. Something like that. I don't really understand why or exactly when it should display, but it seems clear that we should make the function call work (as it probably did prior to june 2022) rather than remove it. I will open a new issue in a moment and tag you in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi Action Does Nothing

2 participants