Validated uniqueness of TC repr method #4787
Open
+184
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mgarrard
force-pushed
the
export-D91011862
branch
from
4052656 to
570bd1b
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Reviewed By: saitcakmak Differential Revision: D91011862
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Reviewed By: saitcakmak Differential Revision: D91011862
mgarrard
force-pushed
the
export-D91011862
branch
from
570bd1b to
936235e
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Reviewed By: saitcakmak Differential Revision: D91011862
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4787 +/- ##
==========================================
- Coverage 96.71% 96.71% -0.01%
==========================================
Files 586 586
Lines 61307 61320 +13
==========================================
+ Hits 59296 59306 +10
- Misses 2011 2014 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Reviewed By: saitcakmak Differential Revision: D91011862
mgarrard
force-pushed
the
export-D91011862
branch
from
936235e to
79c4c5a
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Reviewed By: saitcakmak Differential Revision: D91011862
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Reviewed By: saitcakmak Differential Revision: D91011862
Summary: To align with our standards of only using serializationmixin inheritance in ax objects that are comprised of basic properties (ie not composed of other ax objects), this diff removes the serialization mixin inheritance from TransitionCriteria and better leverages custom encoders/decoders instead. Reviewed By: saitcakmak Differential Revision: D90802656
…#4507) Summary: This is step 1 to making `transition_to` a required argument on TC. We'll make maxparallelism point to self, since it should stay on it's current node when met or unmet. Reviewed By: saitcakmak Differential Revision: D86066476
Summary: This was used by AEPsych and is a legacy completion criterion, the functionality can be replaced with MinTrials and brings up one step closer to being able to reap completion criteria Reviewed By: saitcakmak Differential Revision: D91011637
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Reviewed By: saitcakmak Differential Revision: D91011862
mgarrard
force-pushed
the
export-D91011862
branch
from
79c4c5a to
2376d6e
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 24, 2026
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Reviewed By: saitcakmak Differential Revision: D91011862
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 24, 2026
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Reviewed By: saitcakmak Differential Revision: D91011862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state
Differential Revision: D91011862