Skip to content

Consolidate sources #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Consolidate sources #89

merged 2 commits into from
Aug 21, 2024

Conversation

qdeslandes
Copy link
Contributor

Reorganize the source tree to make bpfilter more modular and avoid building the same source file multiple times.

With bfcli being introduced in 90a6136, src/core sources were used outside of the bpfilter daemon, some other features of the build process have also been disabled (or broken) over time.

This change reorganize the sources into:

  • src: sources for all the project's byproducts: daemon, library, cli. This directory is modular, it contains core, shared, lib, ... Which can then be used to build other binaries. For example, core and xlate are used to build bfcli.
  • tests: mostly unit tests for now. End-to-end tests have been removed in a previous commit, as they were unused.
  • doc: documentation, unmodified except for the coverage target.

lib and cli have been removed, as they also depend on src/core, so they are now modules in src.

End-to-end tests have been sitting unused in the tests folder since they
have been created. It's not worth keeping them around anymore.
Reorganize the source tree to make bpfilter more modular and avoid
building the same source file multiple times.

With bfcli being introduced in 90a6136, src/core sources were used
outside of the bpfilter daemon, some other features of the build process
have also been disabled (or broken) over time.

This change reorganize the sources into:
- src: sources for all the project's byproducts: daemon, library, cli.
  This directory is modular, it contains core, shared, lib, ... Which
  can then be used to build other binaries. For example, core and xlate
  are used to build bfcli.
- tests: mostly unit tests for now. End-to-end tests have been removed
  in a previous commit, as they were unused.
- doc: documentation, unmodified except for the coverage target.

lib and cli have been removed, as they also depend on src/core, so they
are now modules in src.
@qdeslandes qdeslandes merged commit 1870f3e into facebook:main Aug 21, 2024
13 checks passed
@qdeslandes qdeslandes deleted the tidiyup branch August 21, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants