Improve documentation about build configuration #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D89872976. (Because this pull request was imported automatically, there will not be any future comments.) |
cbarrete
force-pushed
the
config-docs
branch
2 times, most recently
from
10fb610 to
d9f780f
Compare
Contributor
cormacrelf
reviewed
Jan 9, 2026
Contributor
cormacrelf
left a comment
cormacrelf
left a comment
There was a problem hiding this comment.
This is great work, very valuable docs. Wish this had been around 2 years ago. I have mostly small comments but one big one on exec platforms.
cbarrete
commented
Jan 11, 2026
Contributor
Author
cbarrete
left a comment
cbarrete
left a comment
There was a problem hiding this comment.
Thanks for the review!
cbarrete
commented
Jan 12, 2026
Contributor
Author
cbarrete
left a comment
cbarrete
left a comment
There was a problem hiding this comment.
@cormacrelf I've left some threads open in case you wanted to comment further. Can you please resolve them if you have no more concerns about them?
cormacrelf
reviewed
Jan 12, 2026
Contributor
|
For some reason Github won't let me resolve any threads so anything I didn't comment on further is lgtm |
This commit rearranges existing documentation and adds more explanation, including a comprehensive overview of the various parts (platforms, modifiers and transitions), and how they are relevant for end users. In particular, a lot of information was moved from `rule_authors/` to `concepts/`, as build configuration is important for end users. A lot of information was also deduplicated across pages.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit rearranges existing documentation and adds more explanation, including a comprehensive overview of the various parts (platforms, modifiers and transitions), and how they are relevant for end users.
In particular, a lot of information was moved from
rule_authors/toconcepts/, as build configuration is important for end users.A lot of information was also deduplicated across pages.