Skip to content

Make soft_error not fail in OSS when quiet = True #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scottcao wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make soft_error not fail in OSS when quiet = True #1199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/buck2_env/src/soft_error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ pub fn handle_soft_error(
ALL_SOFT_ERROR_COUNTERS.lock().unwrap().push(count);
});

let quiet = options.quiet;

// We want to limit each error to appearing at most 10 times in a build (no point spamming people)
if count.fetch_add(1, Ordering::SeqCst) < 10 {
if let Some(handler) = HANDLER.get() {
Expand All @@ -220,9 +222,10 @@ pub fn handle_soft_error(

// @oss-disable: let is_open_source = false;
let is_open_source = true; // @oss-enable
if is_open_source {
if is_open_source && !quiet {
// We don't log these, and we have no legacy users, and they might not upgrade that often,
// so lets just break open source things immediately.
// so lets just break open source things immediately. We only do this when quiet = False
// because we typically use quiet = True for logging purposes.
return Err(err);
}

Expand Down
Loading