feat(core): add i18n.localeConfigs.translate + skip translation process if i18n/<locale> dir doesn't exist
#11304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: new feature
7 tasks
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +1.45 kB (+0.01%) Total Size: 11.5 MB
ℹ️ View Unchanged
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Size Change: +1.47 kB (+0.01%) Total Size: 11.9 MB
ℹ️ View Unchanged
|
slorber
changed the title
i18n.localeConfigs.translate + skip translation process if i18n/<locale> dir doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
An unlocalized site with
defaultLocale: 'en'might provide "label overrides" through thei18nfolder.But in practice:
i18n/eni18n/enfolder doesn't even exist (and caused troubles in Labels do not have unique translation keys #10913)To avoid this, let's disable the translation process if the
./i18n/<currentLocale>dir doesn't exist, so that we don't do extra useless work.This will also impact localized sites; however, it's unusual for an English site localized in French to not have a
i18n/frdir, so in practice the impact should mostly be for the default locale.This will also prevent Docusaurus from reporting translation key conflicts on sites that are not translated (see #10913)
It's possible to use the new
i18n.localeConfigs[<locale>].translate = trueoption to restore the former behavior if this new behavior cause any problem.Test Plan
CI + unit tests
Test links
https://deploy-preview-11304--docusaurus-2.netlify.app/
Related issues/PRs
Follow-up of #10913