test: fix site test infinite loop in Jest --watch mode + simplify test#11312
Merged
test: fix site test infinite loop in Jest --watch mode + simplify test#11312
Conversation
slorber
added
pr: ignore
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +194 B (0%) Total Size: 11.5 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +184 B (0%) Total Size: 11.9 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
yarn test packages/docusaurus/src/server/__tests__/site.test.ts --watchThis runs in an infinite loop due to files emitted by sites in
.docusaurus. Fixed by ignoring this codegen path in Jest watch config.Also took the opportunity to simplify a bit that test.
Test Plan
CI