IceTea: Support mgmt port on IceTea #623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shiva-menta has imported this pull request. If you are a Meta employee, you can view this in D86127017. |
cel-gl
force-pushed
the
Add_icetea_mgmt_port
branch
from
2a6cc8d to
87e0ce5
Compare
Contributor
|
@cel-gl has updated the pull request. You must reimport the pull request before landing. |
|
@shiva-menta merged this pull request in 0db2aae. |
cel-gl
commented
Nov 19, 2025
| } | ||
| return SaiBcmPlatformPort::getPhysicalLaneId(chipId, logicalLane); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
hi @shiva-menta , I found in main branch , this change is not merged? which will make mgmt port init fail, can you have a look
Contributor
There was a problem hiding this comment.
@cel-gl Can you try rebasing? This looks merged in on my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IceTea: Support mgmt port on IceTea , refer icecube mgmt port PR merged #600
Motivation
Due to an SAI issue, IceTea previously did not have management port configuration enabled.
The patch provided by Broadcom has largely fixed this issue, and the management port can now initialize and achieve link-up normally in FBOSS.
Test Plan
1.Build a new wedge_agent-sai_impl include mgmt port configuration
2.The wedge_agent can initialize successfully
3. fboss2 can get mgmt port status