wedge800cact: QSFP/Led service code changes for new platform. #649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
I've already run the test commands for the
led_service, specifically the two test cases: LED color change and LED color blinking.i Test led color change:
./led_service_hw_test --gtest_filter=LedServiceTest.checkLedColorChange --led-config /tmp/led.conf --visual_delay_sec 2(2 seconds is easy to observe)
ii Test led color blinking:
./led_service_hw_test --gtest_filter=LedServiceTest.checkLedBlinking --led-config /tmp/led.conf --visual_delay_sec 4(4 seconds is easy to observe)
Note:
(led-config)
I have tested the QSFP hardware test item for
t0_qsfp_hw_test. The test commands is as follows:Description:
The new wedge800cact platform requires the execution of the following T0 Validation Tests:
Based on the above requirements, I need to add new files to support the new platform for testing.
Following the "New Platform Support" section in the fboss documentation, I have added and modified the following files:
Add:
Modify:
Despite the files added and modified above, further changes to the following files are necessary to ensure the tests run successfully:
Additional changes:
Test Plan
LED Service Hw Test:
To verify the LED colors and blinking status are correct,
based on the specifications defined in
Wedge800CACTBspPlatformMapping.cpp.(1) Test led color change:

Test command:
./led_service_hw_test --gtest_filter=LedServiceTest.checkLedColorChange --led-config /tmp/led.conf --visual_delay_sec 1Checking: Observe whether the LED color changes align with the messages in the test log.
(2) Test led blinking:

Test command:
./led_service_hw_test --gtest_filter=LedServiceTest.checkLedBlinking --led-config /tmp/led.conf --visual_delay_sec 1Checking: Observe whether the LED color and blinking rate (or speed) correspond to the messages in the test log.
QSFP Hardware Tests:
Ensure that the test is executed using the
t0_qsfp_hw_tests.confconfiguration file,and all test items contained within it are successful.
Test Setup:
(Port 1 and Port 2),
(Port 3 and Port 4),
(Port 5 and Port 6)
...
(Port 31 and Port 32) are connected, utilizing the allowed vendor's module: INNOLIGHT (T-OL8CNT-NFM), Eoptolink(EOLO-168HG-02-1B).
Test command:

run_test.py qsfp \ --filter_file=./share/hw_sanity_tests/t0_qsfp_hw_tests.conf \ --qsfp-config ./share/qsfp_test_configs/wedge800cact.materialized_JSONTest log: 20251111_led_and_qsfp_hw_t0_test_log.zip