[Nexthop] Build Distro image in CI #707
Closed
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is a stacked PR where the required PRs are represented as commits. The real change for this PR is this commit. |
travisb-nexthop
force-pushed
the
distro_image_ci
branch
from
0c2f9cb to
1327125
Compare
travisb-nexthop
force-pushed
the
distro_image_ci
branch
from
1327125 to
a7da3ba
Compare
[Nexthop] Fix linting of Distro Image Shell scripts The newly introduced shell linter causes the trivial rebasing of the later Distro Image PRs to fail with many lint errors. Rather than adding a lot of noise to those PRs, re-lint new shell scripts separately. There are two functional fixes in build_image.sh here which seem to have been broken by previous linting efforts: 1. DOCKER_BUILD_ARGS optionally constructs arguments for `docker build`, it must not be quoted when used on the command line or docker will receive an invalid option (because it contains literal spaces). 2. DOCKER_ARGS is similarly constructed to factor out common options between the interactive and non-interactive cases. It must also not be quoted. All other changes are automatically applied by pre-commit.
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. --> **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` <!-- Explain the motivation for making this change and any other context that you think would help reviewers of your code. What existing problem does the pull request solve? --> This is the start of the Distro Image CI where the Distro Image is built. This simply invokes the `fboss-image build` command against the sample `from_source.json` image manifest. The resulting artifacts are not preserved in this PR. As part of this it is necessary to remove `-it` from the docker command because GHA's don't have a stdin. Further the sample image manifest now requires all components be present, so add them. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? --> <!-- If a relevant Github issue exists for this PR, please make sure you link that issue to this PR --> Look at the new workflow in this PR.
travisb-nexthop
force-pushed
the
distro_image_ci
branch
from
a7da3ba to
ed84db2
Compare
Contributor
|
@travisb-nexthop has updated the pull request. You must reimport the pull request before landing. |
Contributor
Author
|
Imported as part of PR709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This is the basic Distro Image CI where the Distro Image is built. This simply invokes the
fboss-image buildcommand against the samplefrom_source.jsonimage manifest.The resulting artifacts are not preserved in this PR.
As part of this it is necessary to remove
-itfrom the docker commandbecause GHA's don't have a stdin. Further the sample image manifest now
requires all components be present, so add them.
Test Plan
Look at the new workflow results in this PR.