[Nexthop] Add Docker support for FBOSS Image Builder#799
Closed
raghav-nexthop wants to merge 3 commits intofacebook:mainfrom
Closed
[Nexthop] Add Docker support for FBOSS Image Builder#799raghav-nexthop wants to merge 3 commits intofacebook:mainfrom
raghav-nexthop wants to merge 3 commits intofacebook:mainfrom
Conversation
raghav-nexthop
force-pushed
the
raghav.distro-cli-docker-part3
branch
2 times, most recently
from
cf3dfe9 to
6d2a3bb
Compare
raghav-nexthop
force-pushed
the
raghav.distro-cli-docker-part3
branch
4 times, most recently
from
75eb298 to
f2673ec
Compare
raghav-nexthop
force-pushed
the
raghav.distro-cli-docker-part3
branch
from
f2673ec to
6037c61
Compare
Contributor
|
@raghav-nexthop has updated the pull request. You must reimport the pull request before landing. |
raghav-nexthop
force-pushed
the
raghav.distro-cli-docker-part3
branch
from
6037c61 to
d1b288c
Compare
Contributor
|
@raghav-nexthop has updated the pull request. You must reimport the pull request before landing. |
raghav-nexthop
force-pushed
the
raghav.distro-cli-docker-part3
branch
from
d1b288c to
c9dbcad
Compare
Contributor
|
@raghav-nexthop has updated the pull request. You must reimport the pull request before landing. |
raghav-nexthop
force-pushed
the
raghav.distro-cli-docker-part3
branch
from
c9dbcad to
df25910
Compare
Contributor
|
@raghav-nexthop has updated the pull request. You must reimport the pull request before landing. |
raghav-nexthop
force-pushed
the
raghav.distro-cli-docker-part3
branch
from
df25910 to
e83b4cd
Compare
Contributor
|
@raghav-nexthop has updated the pull request. You must reimport the pull request before landing. |
Integrate distro_cli Python unit tests into the FBOSS CMake build system to enable automated testing in CI/CD pipelines. - Add FbossImageDistroCliTests.cmake to discover and register Python unit tests - Configure test discovery for distro_cli modules (builder, cmds, lib, tools) - Update root CMakeLists.txt to include distro_cli test suite - Enable distro_cli tests in GitHub Actions workflow - Update distro_cli README with build and test instructions The CMake configuration automatically discovers all *_test.py files and registers them as CTest targets, allowing tests to run via 'ctest' or 'make test'.
Provide basic tools and utiulities for the distro_cli build system. - Add custom exception classes for structured error handling - Define shared constants for Docker configuration and build settings - Implement path resolution utilities for components - Define test data fixture for image manifest validation These core utilities provide the base infrastructure required by all downstream components including Docker integration, artifact handling, and build orchestration.
Add Docker container and image management capabilities. - Implement Docker container wrapper with exec and run operations - Implement Docker image wrapper with build, pull, and tag operations - Add comprehensive unit tests for container and image functionality - Include test helper utilities for unit test infrastructure - Add build_docker.sh script for Docker build automation Added unit tests for docker infrastructure and image building.
raghav-nexthop
force-pushed
the
raghav.distro-cli-docker-part3
branch
from
e83b4cd to
d644f72
Compare
Contributor
|
@raghav-nexthop has updated the pull request. You must reimport the pull request before landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Add Docker container and image management capabilities.
Test Plan
Added unit tests for docker infrastructure and image building.