[Nexthop] Add missing fsdb_utils dependency to thriftpath_lib #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This build was sometimes failing when compiling `fboss/thriftpath_plugin/Path.cpp` with the error: fatal error: fboss/thrift_cow/visitors/gen-cpp2/results_types.h: No such file or directory The header `results_types.h` is a generated file that depends on the `cow_visitor_results_cpp2` target. While the BUCK configuration for `thriftpath_plugin/Path.cpp` correctly includes `//fboss/fsdb/common:utils` as a dependency, the corresponding CMake target (thriftpath_lib) was missing a link to `fsdb_utils`. This caused a missing trigger for the Thrift code generation during the CMake build. **Solution:** Added `fsdb_utils` to target_link_libraries in `cmake/fsdb/FsdbIf.cmake` to align the CMake build with the BUCK ground-truth. Verified the dependency chain in `FsdbCommon.cmake` and `ThriftCowVisitors.cmake` to confirm `fsdb_utils` correctly maps to the missing `results_types.h` generator. Thanks to Darius Grassi for fixing this issue.
|
@joseph5wu has imported this pull request. If you are a Meta employee, you can view this in D91263155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This build was sometimes failing when compiling
fboss/thriftpath_plugin/Path.cppwith the error:The header
results_types.his a generated file that depends on thecow_visitor_results_cpp2target. While the BUCK configuration forthriftpath_plugin/Path.cppcorrectly includes//fboss/fsdb/common:utilsas a dependency, the corresponding CMake target (thriftpath_lib) was missing a link tofsdb_utils. This caused a missing trigger for the Thrift code generation during the CMake build.Solution: Added
fsdb_utilsto target_link_libraries incmake/fsdb/FsdbIf.cmaketo align the CMake build with the BUCK ground-truth.Verified the dependency chain in
FsdbCommon.cmakeandThriftCowVisitors.cmaketo confirmfsdb_utilscorrectly maps to the missingresults_types.hgenerator.Thanks to Darius Grassi @darius-nexthop for fixing this issue.
Test Plan
Not needed.