tc-print: show PC-relative literal values in offline AArch64 disasm #9699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D89730220. (Because this pull request was imported automatically, there will not be any future comments.) |
ottoni
requested changes
Jan 28, 2026
| auto const literalAddr = frontier->LiteralAddress(); | ||
| auto const codeBegin = reinterpret_cast<uint8_t*>(code); | ||
| auto const codeEnd = codeBegin + codeLen; | ||
| if (literalAddr >= codeBegin && literalAddr + literalSize <= codeEnd) { |
Contributor
There was a problem hiding this comment.
The <= should be < instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.