Skip to content

Conversation

@screenfluent
Copy link

@screenfluent screenfluent commented Feb 3, 2026

Fixes #8112.

This replaces a couple of short fixed sleeps in packages/lexical-playground/tests/e2e/Collaboration.spec.mjs with explicit waits:

  • Wait for the Undo button to be enabled before clicking (removes sleep(50)).
  • Wait for both editors to converge after the first delete before performing the second cross-frame delete (removes sleep(50)).

No behavior assertions changed; this only makes the existing test steps more deterministic.

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lexical Ready Ready Preview, Comment Feb 3, 2026 9:01pm
lexical-playground Ready Ready Preview, Comment Feb 3, 2026 9:01pm

Request Review

@meta-cla
Copy link

meta-cla bot commented Feb 3, 2026

Hi @screenfluent!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@etrepum
Copy link
Collaborator

etrepum commented Feb 4, 2026

This PR can't be considered without acceptance of the CLA, and it seems to be failing the prettier ci-check. pnpm run prettier:fix should address that issue.

@meta-cla
Copy link

meta-cla bot commented Feb 4, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2026
@meta-cla
Copy link

meta-cla bot commented Feb 4, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky WebKit collab E2E tests in playground (sleep(50) too short)

2 participants