Skip to content

Upgrade GitHub Actions for Node 24 compatibility #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salmanmkc wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

Upgrade GitHub Actions for Node 24 compatibility #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/getdeps_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
build:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Update system package info
run: sudo --preserve-env=http_proxy apt-get update
- name: Install system deps
Expand Down Expand Up @@ -523,7 +523,7 @@ jobs:
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mvfst --project-install-prefix mvfst:/usr/local
- name: Copy artifacts
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --strip --src-dir=. mvfst _artifacts/linux --project-install-prefix mvfst:/usr/local --final-install-prefix /usr/local
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v6
with:
name: mvfst
path: _artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/getdeps_mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
build:
runs-on: macOS-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Install system deps
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages install-system-deps --recursive mvfst
- id: paths
Expand Down Expand Up @@ -483,7 +483,7 @@ jobs:
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mvfst --project-install-prefix mvfst:/usr/local
- name: Copy artifacts
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --src-dir=. mvfst _artifacts/mac --project-install-prefix mvfst:/usr/local --final-install-prefix /usr/local
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v6
with:
name: mvfst
path: _artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/getdeps_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
git config --system core.autocrlf false &&
git config --system core.symlinks true
shell: cmd
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- id: paths
name: Query paths
run: python build/fbcode_builder/getdeps.py query-paths --recursive --src-dir=. mvfst >> $env:GITHUB_OUTPUT
Expand Down Expand Up @@ -453,7 +453,7 @@ jobs:
run: python build/fbcode_builder/getdeps.py build --src-dir=. mvfst
- name: Copy artifacts
run: python build/fbcode_builder/getdeps.py fixup-dyn-deps --src-dir=. mvfst _artifacts/windows --final-install-prefix /usr/local
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v6
with:
name: mvfst
path: _artifacts
Expand Down