Add granular CMake targets with BUILD_SHARED_LIBS support #423
+2,464
−2,235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Similar to the folly, fizz, and wangle granular CMake implementations, this adds granular library targets for mvfst that work with both static and shared library builds. Key changes: - Added MvfstFunctions.cmake with mvfst_add_library() function - Creates OBJECT libraries for compile-once, use-many pattern - Creates STATIC libraries (static builds) or INTERFACE libraries linking to monolithic mvfst (shared builds) - Added generate_cmake.py to auto-generate CMakeLists.txt from BUCK files - Added lint_cmake_sync.py for arc lint integration - Added MvfstCompatAliases.cmake for backwards compatibility with old target names used by downstream projects (proxygen, moxygen, thrift) Backwards compatibility aliases properly include all transitive dependencies that the old targets had (e.g., mvfst_server now includes qlogger and fizz server handshake). Differential Revision: D91009061
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Similar to the folly, fizz, and wangle granular CMake implementations, this adds
granular library targets for mvfst that work with both static and shared library
builds.
Key changes:
to monolithic mvfst (shared builds)
names used by downstream projects (proxygen, moxygen, thrift)
Backwards compatibility aliases properly include all transitive dependencies
that the old targets had (e.g., mvfst_server now includes qlogger and fizz
server handshake).
Differential Revision: D91009061