make --remove-unused-ignores a no-op for files with no unused ignores #2217
+30
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmacon
reviewed
Jan 24, 2026
gmacon
left a comment
gmacon
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for implementing this.
Comment on lines
+377
to
380
| if ignore.is_empty() { | ||
| continue; | ||
| } | ||
| all_ignores.insert(path, ignore); |
There was a problem hiding this comment.
I might structure this with a negative condition and avoid the continue, i.e.
Suggested change
| if ignore.is_empty() { | |
| continue; | |
| } | |
| all_ignores.insert(path, ignore); | |
| if !ignore.is_empty() { | |
| all_ignores.insert(path, ignore); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2185
This change makes
--remove-unused-ignoresavoid rewriting files when there are no unused ignores to remove.Files that have no ignore comments, or only have used ignore comments, are now left untouched. This prevents unnecessary file writes and avoids introducing formatting-only changes such as added newlines.
Test Plan
Added tests to verify no newline characters are appended to input when there are no unused ignores to remove.