Update public API for intrinsic sizing setters #46939
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002837 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 10, 2024
Summary: X-link: facebook/react-native#46939 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Differential Revision: D64002837
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Oct 10, 2024
Summary: X-link: facebook/yoga#1722 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Differential Revision: D64002837
joevilches
force-pushed
the
export-D64002837
branch
from
9447363 to
04ae02b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002837 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 29, 2024
Summary: X-link: facebook/react-native#46939 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Reviewed By: NickGerleman Differential Revision: D64002837
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Oct 29, 2024
Summary: X-link: facebook/yoga#1722 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Reviewed By: NickGerleman Differential Revision: D64002837
joevilches
force-pushed
the
export-D64002837
branch
from
04ae02b to
1c67b85
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002837 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 30, 2024
Summary: X-link: facebook/react-native#46939 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Reviewed By: NickGerleman Differential Revision: D64002837
joevilches
force-pushed
the
export-D64002837
branch
from
1c67b85 to
dfad435
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Oct 30, 2024
Summary: X-link: facebook/yoga#1722 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Reviewed By: NickGerleman Differential Revision: D64002837
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002837 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 31, 2024
Summary: X-link: facebook/react-native#46939 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Reviewed By: NickGerleman Differential Revision: D64002837
joevilches
force-pushed
the
export-D64002837
branch
from
dfad435 to
2d5f275
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Oct 31, 2024
Summary: X-link: facebook/yoga#1722 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Reviewed By: NickGerleman Differential Revision: D64002837
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002837 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 31, 2024
Summary: X-link: facebook/react-native#46939 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Reviewed By: NickGerleman Differential Revision: D64002837
joevilches
force-pushed
the
export-D64002837
branch
from
2d5f275 to
530b86f
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Oct 31, 2024
Summary: X-link: facebook/yoga#1722 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Reviewed By: NickGerleman Differential Revision: D64002837
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002837 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Nov 1, 2024
Summary: X-link: facebook/react-native#46939 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Reviewed By: NickGerleman Differential Revision: D64002837
joevilches
force-pushed
the
export-D64002837
branch
from
530b86f to
b5b4759
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Nov 1, 2024
Summary: X-link: facebook/yoga#1722 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Reviewed By: NickGerleman Differential Revision: D64002837
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002837 |
joevilches
force-pushed
the
export-D64002837
branch
from
b5b4759 to
1fe9e15
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Nov 4, 2024
Summary: X-link: facebook/yoga#1722 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D64002837
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002837 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Nov 4, 2024
Summary: X-link: facebook/react-native#46939 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D64002837
… keywords (facebook#46938) Summary: X-link: facebook/yoga#1721 The private internals of how we store styles needed to change a bit to support 3 new keyword values. Right now the only other keyword that can be stored is `auto`. As a result there isn't much fancy logic to support storing this and its just stored as a specific type inside of `StyleValueHandle`. There are only 3 bits for types (8 values), so it is not sustainable to just stuff every keyword in there. So the change writes the keyword as a value with a new `keyword` `Type`. I chose not to put `auto` in there even though it is a keyword since it is a hot path, I did not want to regress perf when I did not need to. I also make a new `StyleSizeValue` class to store size values - so values for `width`, `height`, etc. This way these new keywords are kept specific to sizes and we will not be able to create, for example, a margin: `max-content`. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63927512
Summary: X-link: facebook/yoga#1722 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D64002837
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Nov 4, 2024
Summary: X-link: facebook/react-native#46939 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D64002837
joevilches
force-pushed
the
export-D64002837
branch
from
1fe9e15 to
866d368
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002837 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 5, 2024
Summary: X-link: facebook/react-native#46939 X-link: facebook/yoga#1722 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D64002837 fbshipit-source-id: f15fae9fc0103175e1d85850fc9aa68579989fd3
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Nov 5, 2024
Summary: X-link: facebook/react-native#46939 Pull Request resolved: #1722 tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D64002837 fbshipit-source-id: f15fae9fc0103175e1d85850fc9aa68579989fd3
Contributor
|
This pull request has been merged in c9a9671. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/yoga#1722
tsia! opted for one function for each keyword just like auto. This is kinda annoying and not the most sustainable, so maybe it makes more sense to make a new enum here and just add one function
Differential Revision: D64002837