Migrate ReactPackageTurboModuleManagerDelegate to Kotlin
#51855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
reviewed
Jun 6, 2025
| @@ -77,7 +77,7 @@ public abstract class LazyReactPackage : ReactPackage { | |||
| * @param reactContext react application context that can be used to create modules | |||
| * @return list of module specs that can create the native modules | |||
| */ | |||
| protected abstract fun getNativeModules(reactContext: ReactApplicationContext): List<ModuleSpec> | |||
There was a problem hiding this comment.
Why are you changing this?
There was a problem hiding this comment.
It is being accessed here: https://github.com/facebook/react-native/pull/51855/files#diff-8e5e67fbf42add63f615a128dc2009c2474e5303765d33a64edcc301a3ee80b7R74 – would you know if there is a way to avoid having to make this public?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Migrate com.facebook.react.ReactPackageTurboModuleManagerDelegate to Kotlin.
Changelog:
[INTERNAL] - Migrate com.facebook.react.ReactPackageTurboModuleManagerDelegate to Kotlin
Test Plan: