Add react-strict-dom/postcss-plugin based on @stylexjs/postcss-plugin#308
Merged
necolas merged 2 commits intofacebook:mainfrom Jul 3, 2025
Merged
Add react-strict-dom/postcss-plugin based on @stylexjs/postcss-plugin#308necolas merged 2 commits intofacebook:mainfrom
necolas merged 2 commits intofacebook:mainfrom
Conversation
1 task
necolas
reviewed
May 17, 2025
javascripter
force-pushed
the
postcss-plugin-stylex
branch
from
c15ca25 to
b455d43
Compare
Contributor
|
#311 updates StyleX to 0.13 |
javascripter
force-pushed
the
postcss-plugin-stylex
branch
3 times, most recently
from
6f876b3 to
f68164a
Compare
Contributor
Author
|
Rebased from main and updated to use |
Contributor
|
This PR aims to avoid the Expo warnings facebook/stylex#1087 |
Contributor
|
We should be able to proceed with this change now that the StyleX upgrade is done |
javascripter
force-pushed
the
postcss-plugin-stylex
branch
from
f68164a to
d594216
Compare
Contributor
Author
|
@necolas |
necolas
force-pushed
the
postcss-plugin-stylex
branch
from
d594216 to
a16d890
Compare
necolas
force-pushed
the
postcss-plugin-stylex
branch
from
a16d890 to
f8e7aca
Compare
necolas
approved these changes
Jul 3, 2025
Contributor
necolas
left a comment
necolas
left a comment
There was a problem hiding this comment.
Thanks for your patience and another great PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#281 (comment)
This PR upstreams postcss-react-strict-dom to the official repo to make it easier for maintainers to make changes.
I added RSD compatibility to
@stylexjs/postcss-pluginin this PR, so this addsreact-strict-dom/postcss-pluginthat re-exports the StyleX PostCSS Plugin with the required configuration for RSD consumers.How
packages/react-strict-dom/postcss/plugin.jsreact-strict-dom/postcss-pluginin package.jsonapps/examplesto use the official plugin and removed postcss-react-strict-dom dependencyTest Plan
cd apps/example && npm run dev:webboth from the original repo and this branch and compare side-by-side to make sure output matchesLeft is this branch, right is original
