Only set userSelect:auto on anchor tags (native)#324
Merged
Conversation
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
There was a problem hiding this comment.
I've done some practical checks, and:
- on iOS: neither
onPressnoruserSelectstyle triggers keyboard navigation focus. WrappingTextinPressable(or simply<View accessible>) allows for focusing the text. However, when nesting that insideTextyou get whacky layout.
- on Android: having
onPressprop alone is sufficient forTextcomponent to receive keyboard navigation focus (being wrapped inPressableis also fine)
Therefore, I would recommend on not applying userSelect: auto to a elements, as:
- it's not needed on Android, having
onPressprop is enough - it does not work on iOS anyway
- AFAIU the purpose of
userSelectstyle is to allow for user to copy given text, not to make it focusable by keyboard, that would betabIndex/focusableprops (but these work only on Android anyway)
You can check the experiements repo here: https://github.com/mdjastrzebski/repro-rsd-keyboard-navigation
8efcd35 to
560a273
Compare
Contributor
Author
|
Updated to remove it entirely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix #314