Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isUnknownEvent to UpdateType enum #25371

Closed
wants to merge 6 commits into from
Closed

Update isUnknownEvent to UpdateType enum #25371

wants to merge 6 commits into from

Conversation

tyao1
Copy link
Contributor

@tyao1 tyao1 commented Sep 30, 2022 •
edited
Loading

Summary

Based on commits in #25310.
isUnknownEvent was specific for frame aligned update, and we want to unify more types of synchronous update. This PR makes this an enum to support that.

How did you test this change?

yarn lint

@tyao1 tyao1 requested a review from acdlite September 30, 2022 18:30
@sizebot
Copy link

sizebot commented Sep 30, 2022 •
edited
Loading

Comparing: cb5084d...3f9e2cc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.14% 135.28 kB 135.46 kB +0.16% 43.39 kB 43.46 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.62% 142.74 kB 143.63 kB +0.56% 45.58 kB 45.84 kB
facebook-www/ReactDOM-prod.classic.js +0.58% 490.70 kB 493.54 kB +0.61% 87.32 kB 87.85 kB
facebook-www/ReactDOM-prod.modern.js +0.61% 475.99 kB 478.87 kB +0.70% 85.13 kB 85.73 kB
facebook-www/ReactDOMForked-prod.classic.js +0.58% 490.70 kB 493.54 kB +0.61% 87.32 kB 87.85 kB
oss-experimental/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-stable-semver/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-stable/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-experimental/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB
oss-stable-semver/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB
oss-stable/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-stable-semver/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-stable/jest-react/cjs/jest-react.production.min.js +6.77% 2.42 kB 2.59 kB +3.42% 1.17 kB 1.21 kB
oss-experimental/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB
oss-stable-semver/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB
oss-stable/jest-react/cjs/jest-react.development.js +2.61% 10.61 kB 10.89 kB +1.49% 3.75 kB 3.80 kB
facebook-www/ReactIs-dev.modern.js +0.78% 9.62 kB 9.70 kB +0.47% 2.54 kB 2.55 kB
facebook-www/ReactIs-dev.classic.js +0.78% 9.62 kB 9.70 kB +0.47% 2.54 kB 2.55 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.72% 12.43 kB 12.52 kB +0.51% 3.72 kB 3.74 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.72% 12.43 kB 12.52 kB +0.51% 3.72 kB 3.74 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.72% 12.43 kB 12.52 kB +0.51% 3.72 kB 3.74 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.72% 12.50 kB 12.59 kB +0.48% 3.74 kB 3.75 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.72% 12.50 kB 12.59 kB +0.48% 3.74 kB 3.75 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.72% 12.50 kB 12.59 kB +0.48% 3.74 kB 3.75 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.62% 142.74 kB 143.63 kB +0.56% 45.58 kB 45.84 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js +0.61% 146.09 kB 146.98 kB +0.59% 46.98 kB 47.26 kB
facebook-www/ReactDOM-prod.modern.js +0.61% 475.99 kB 478.87 kB +0.70% 85.13 kB 85.73 kB
facebook-www/ReactDOMForked-prod.modern.js +0.61% 475.99 kB 478.87 kB +0.70% 85.13 kB 85.73 kB
facebook-www/ReactDOM-profiling.modern.js +0.59% 505.81 kB 508.81 kB +0.65% 89.66 kB 90.24 kB
facebook-www/ReactDOMForked-profiling.modern.js +0.59% 505.81 kB 508.81 kB +0.65% 89.66 kB 90.24 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js +0.58% 152.22 kB 153.11 kB +0.53% 47.97 kB 48.23 kB
facebook-www/ReactDOM-prod.classic.js +0.58% 490.70 kB 493.54 kB +0.61% 87.32 kB 87.85 kB
facebook-www/ReactDOMForked-prod.classic.js +0.58% 490.70 kB 493.54 kB +0.61% 87.32 kB 87.85 kB
facebook-www/ReactDOM-profiling.classic.js +0.57% 520.58 kB 523.55 kB +0.58% 91.90 kB 92.44 kB
facebook-www/ReactDOMForked-profiling.classic.js +0.57% 520.58 kB 523.55 kB +0.58% 91.90 kB 92.44 kB
oss-experimental/react-dom/umd/react-dom.production.min.js +0.52% 142.78 kB 143.53 kB +0.63% 46.25 kB 46.55 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js +0.49% 151.59 kB 152.34 kB +0.64% 48.54 kB 48.85 kB
facebook-www/ReactART-dev.modern.js +0.42% 846.03 kB 849.55 kB +0.38% 178.74 kB 179.41 kB
facebook-www/ReactART-dev.classic.js +0.41% 856.25 kB 859.77 kB +0.36% 180.81 kB 181.47 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js +0.40% 103.27 kB 103.69 kB +0.40% 31.64 kB 31.77 kB
facebook-www/ReactDOMForked-dev.modern.js +0.40% 1,220.05 kB 1,224.90 kB +0.34% 267.31 kB 268.21 kB
facebook-www/ReactDOM-dev.modern.js +0.40% 1,220.05 kB 1,224.90 kB +0.34% 267.31 kB 268.21 kB
facebook-www/ReactDOMForked-dev.classic.js +0.39% 1,243.68 kB 1,248.53 kB +0.33% 271.60 kB 272.50 kB
facebook-www/ReactDOM-dev.classic.js +0.39% 1,243.68 kB 1,248.53 kB +0.33% 271.60 kB 272.50 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js +0.37% 112.12 kB 112.54 kB +0.41% 33.73 kB 33.87 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js +0.34% 1,088.10 kB 1,091.79 kB +0.31% 243.43 kB 244.17 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js +0.34% 34.60 kB 34.72 kB +0.33% 7.80 kB 7.83 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js +0.34% 34.60 kB 34.72 kB +0.33% 7.80 kB 7.83 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js +0.34% 34.60 kB 34.72 kB +0.33% 7.80 kB 7.83 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.34% 34.73 kB 34.85 kB +0.33% 7.82 kB 7.84 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.34% 34.73 kB 34.85 kB +0.33% 7.82 kB 7.84 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.34% 34.73 kB 34.85 kB +0.33% 7.82 kB 7.84 kB
oss-experimental/react-dom/cjs/react-dom.development.js +0.33% 1,105.05 kB 1,108.74 kB +0.30% 247.05 kB 247.79 kB
oss-experimental/react-dom/umd/react-dom.development.js +0.33% 1,159.13 kB 1,162.91 kB +0.30% 249.79 kB 250.53 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +0.32% 820.84 kB 823.46 kB +0.25% 174.57 kB 175.00 kB
facebook-www/ReactART-prod.modern.js +0.30% 317.11 kB 318.07 kB +0.35% 54.25 kB 54.44 kB
facebook-www/ReactART-prod.classic.js +0.28% 327.88 kB 328.80 kB +0.31% 56.05 kB 56.23 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.24% 750.52 kB 752.32 kB +0.19% 160.77 kB 161.07 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.24% 750.52 kB 752.32 kB +0.19% 160.77 kB 161.07 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.24% 280.47 kB 281.13 kB +0.23% 49.71 kB 49.82 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.24% 730.88 kB 732.60 kB +0.18% 156.71 kB 156.99 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.23% 779.38 kB 781.20 kB +0.20% 166.39 kB 166.72 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.23% 779.40 kB 781.23 kB +0.20% 166.41 kB 166.75 kB
react-native/implementations/ReactFabric-dev.js +0.23% 808.72 kB 810.56 kB +0.19% 175.57 kB 175.90 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.23% 296.05 kB 296.71 kB +0.23% 52.06 kB 52.18 kB
react-native/implementations/ReactFabric-dev.fb.js +0.22% 843.60 kB 845.46 kB +0.19% 182.13 kB 182.47 kB
react-native/implementations/ReactFabric-prod.js +0.21% 308.59 kB 309.25 kB +0.25% 54.68 kB 54.82 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.21% 818.32 kB 820.04 kB +0.19% 178.13 kB 178.47 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.min.js +0.21% 96.44 kB 96.65 kB +0.27% 29.65 kB 29.73 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js +0.21% 96.47 kB 96.67 kB +0.27% 29.67 kB 29.75 kB
react-native/implementations/ReactFabric-prod.fb.js +0.21% 316.95 kB 317.61 kB +0.23% 56.33 kB 56.46 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +0.20% 853.19 kB 854.91 kB +0.17% 184.72 kB 185.04 kB
react-native/implementations/ReactFabric-profiling.js +0.20% 327.68 kB 328.34 kB +0.24% 57.81 kB 57.95 kB

Generated by 🚫 dangerJS against 3f9e2cc

@tyao1 tyao1 force-pushed the synchronous-enum branch from e469446 to d6e6750 Compare October 4, 2022 23:00
@tyao1 tyao1 force-pushed the synchronous-enum branch from 0b63508 to 3f9e2cc Compare October 5, 2022 00:33
@tyao1
Copy link
Contributor Author

tyao1 commented Oct 11, 2022

redoing it in #25460

@tyao1 tyao1 closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tyao1 @sizebot @facebook-github-bot @rickhanlonii