Skip to content

[ci] Fix --dry not being passed correctly #32489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

[ci] Fix --dry not being passed correctly #32489

merged 1 commit into from
Feb 27, 2025

Conversation

poteto
Copy link
Member

@poteto poteto commented Feb 27, 2025

Boolean params for dry runs are true if the param exists at all, so only add it if we're in dry run mode.

Boolean params for dry runs are true if the param exists at all, so only add it if we're in dry run mode.
@react-sizebot
Copy link

Comparing: 4c9392b...b876368

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.73 kB 515.73 kB = 92.10 kB 92.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 565.65 kB 565.65 kB = 100.87 kB 100.87 kB
facebook-www/ReactDOM-prod.classic.js = 636.71 kB 636.71 kB = 112.07 kB 112.07 kB
facebook-www/ReactDOM-prod.modern.js = 627.03 kB 627.03 kB = 110.49 kB 110.49 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against b759df0

@poteto poteto merged commit 5eb20b3 into main Feb 27, 2025
198 checks passed
@poteto poteto deleted the pr32489 branch February 27, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants