Skip to content

[Flight] Improve owner and component stacks when aborting #34755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[Flight] Improve owner and component stacks when aborting #34755

wants to merge 7 commits into from
+589 −25

Conversation

unstubbable
Copy link
Collaborator

Alternative to #34638, covering not only hanging promises, but also unresolved I/O.

@meta-cla meta-cla bot added the CLA Signed label Oct 6, 2025
@unstubbable unstubbable changed the title [Flight] Improve owner and components stacks when aborting [Flight] Improve owner and components stack when aborting Oct 6, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Oct 6, 2025
@unstubbable unstubbable changed the title [Flight] Improve owner and components stack when aborting [Flight] Improve owner and component stacks when aborting Oct 6, 2025
@unstubbable unstubbable force-pushed the improve-aborted-promise-stacks branch 2 times, most recently from 5e89b83 to b174161 Compare October 6, 2025 16:18
@react-sizebot
Copy link

react-sizebot commented Oct 6, 2025 •
edited
Loading

Comparing: 06fcc8f...5454fe9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 604.98 kB 604.98 kB = 107.14 kB 107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.95 kB 663.95 kB = 117.03 kB 117.03 kB
facebook-www/ReactDOM-prod.classic.js = 687.81 kB 687.81 kB = 121.07 kB 121.07 kB
facebook-www/ReactDOM-prod.modern.js = 678.24 kB 678.24 kB = 119.42 kB 119.42 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.50% 210.78 kB 211.84 kB +0.54% 38.45 kB 38.66 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.50% 210.78 kB 211.84 kB +0.54% 38.45 kB 38.66 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.49% 215.15 kB 216.21 kB +0.47% 39.26 kB 39.44 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +0.49% 217.29 kB 218.35 kB +0.49% 39.14 kB 39.33 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +0.49% 217.29 kB 218.35 kB +0.49% 39.14 kB 39.33 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +0.48% 221.66 kB 222.73 kB +0.46% 39.94 kB 40.13 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.47% 224.00 kB 225.07 kB +0.50% 40.23 kB 40.43 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.47% 224.00 kB 225.07 kB +0.50% 40.23 kB 40.43 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.47% 225.21 kB 226.27 kB +0.47% 40.53 kB 40.72 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.47% 225.21 kB 226.27 kB +0.47% 40.53 kB 40.72 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.47% 225.26 kB 226.32 kB +0.46% 40.54 kB 40.72 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.47% 225.26 kB 226.32 kB +0.46% 40.54 kB 40.72 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.47% 228.37 kB 229.44 kB +0.43% 41.04 kB 41.22 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.46% 229.58 kB 230.64 kB +0.43% 41.34 kB 41.52 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.46% 229.63 kB 230.69 kB +0.44% 41.34 kB 41.52 kB

Generated by 🚫 dangerJS against 5454fe9

sebmarkbage
sebmarkbage reviewed Oct 6, 2025
View reviewed changes
@unstubbable unstubbable force-pushed the improve-aborted-promise-stacks branch 2 times, most recently from d30af01 to 3e5782f Compare October 6, 2025 18:57
@unstubbable
Add six tests for prerendering and aborting in successive tasks
f00ca9d 
when scheduling prerendering and aborting in successive tasks using setImmediate
  ✕ includes deeper location for hanging promises
  ✓ includes deeper location for hanging promises in ignore-listed components
  ! includes deeper location for unresolved I/O (this one is flaky!)
when scheduling prerendering and aborting in successive tasks using setTimeout
  ✓ includes deeper location for hanging promises
  ✕ includes deeper location for hanging promises in ignore-listed components
  ✕ includes deeper location for unresolved I/O
@unstubbable
Fix stacks for aborted hanging promises
f7ac1f5
@unstubbable
Fix stacks for unresolved I/O during abort
eb8b23a
@unstubbable
Remove leftover unnecessary logic
d48d374
@unstubbable unstubbable force-pushed the improve-aborted-promise-stacks branch from 3e5782f to d785334 Compare October 10, 2025 13:52
@unstubbable unstubbable force-pushed the improve-aborted-promise-stacks branch from d785334 to 5454fe9 Compare October 10, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebmarkbage sebmarkbage sebmarkbage left review comments

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@unstubbable @react-sizebot @sebmarkbage