[DevTools] Exclude Suspense boundaries in hidden Activity#34756
Merged
eps1lon merged 2 commits intofacebook:mainfrom Oct 14, 2025
Merged
Conversation
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/10-06-_devtools_don_t_include_suspense_in_hidden_activity
branch
from
21137eb to
2a2cca5
Compare
otodockal
reviewed
Oct 6, 2025
| function App({hidden}) { | ||
| return ( | ||
| <> | ||
| <Activity mode={hidden ? 'hidden' : 'visiible'}> |
There was a problem hiding this comment.
Suggested change
| <Activity mode={hidden ? 'hidden' : 'visiible'}> | |
| <Activity mode={hidden ? 'hidden' : 'visible'}> |
sebmarkbage
reviewed
Oct 7, 2025
| if (isHiddenOffscreen(fiber)) { | ||
| // hidden Activity is noisy. | ||
| // Including it may show overlapping Suspense rects | ||
| } else if (isSuspendedOffscreen(fiber)) { |
Contributor
There was a problem hiding this comment.
Wouldn’t this always be false because isHiddenOffscreen above is a superset of isSuspendedOffscreen?
Collaborator
Author
There was a problem hiding this comment.
Right. I handled the suspended case first in the other places but not here. Now we always handle suspended before hidden.
Though I'm not sure how to make this matter in the mount path. In the current test, fiber.child is always null when mounting a suspended Offscreen. I guess we can't hit this in modern Suspense where we don't commit an inconsistent tree. But I believe React 17 could commit an inconsistent, hidden tree where this would matter?
eps1lon
force-pushed
the
sebbie/10-06-_devtools_don_t_include_suspense_in_hidden_activity
branch
from
2a2cca5 to
3c482be
Compare
sebmarkbage
approved these changes
Oct 14, 2025
eps1lon
deleted the
sebbie/10-06-_devtools_don_t_include_suspense_in_hidden_activity
branch
This was referenced Oct 14, 2025
hoxyq
added a commit
that referenced
this pull request
Oct 20, 2025
Full list of changes: * Text layout fixes for stack traces with badges ([eps1lon](https://github.com/eps1lon) in [#34925](#34925)) * chore: read from build/COMMIT_SHA fle as fallback for commit hash ([hoxyq](https://github.com/hoxyq) in [#34915](#34915)) * fix: dont ship source maps for css in prod builds ([hoxyq](https://github.com/hoxyq) in [#34913](#34913)) * Lower case "rsc stream" debug info ([sebmarkbage](https://github.com/sebmarkbage) in [#34921](#34921)) * BuiltInCallSite should have padding-left ([sebmarkbage](https://github.com/sebmarkbage) in [#34922](#34922)) * Show the Suspense boundary name in the rect if there's no overlap ([sebmarkbage](https://github.com/sebmarkbage) in [#34918](#34918)) * Don't attach filtered IO to grandparent Suspense ([eps1lon](https://github.com/eps1lon) in [#34916](#34916)) * Infer name from stack if it's the generic "lazy" name ([sebmarkbage](https://github.com/sebmarkbage) in [#34907](#34907)) * Use same Suspense naming heuristics when reconnecting ([eps1lon](https://github.com/eps1lon) in [#34898](#34898)) * Assign a different color and label based on environment ([sebmarkbage](https://github.com/sebmarkbage) in [#34893](#34893)) * Compute environment names for the timeline ([sebmarkbage](https://github.com/sebmarkbage) in [#34892](#34892)) * Don't highlight the root rect if no roots has unique suspenders ([sebmarkbage](https://github.com/sebmarkbage) in [#34885](#34885)) * Highlight the rect when the corresponding timeline bean is hovered ([sebmarkbage](https://github.com/sebmarkbage) in [#34881](#34881)) * Repeat the "name" if there's no short description in groups ([sebmarkbage](https://github.com/sebmarkbage) in [#34894](#34894)) * Tweak the rects design and create multi-environment color scheme ([sebmarkbage](https://github.com/sebmarkbage) in [#34880](#34880)) * Adjust the rects size by one pixel smaller ([sebmarkbage](https://github.com/sebmarkbage) in [#34876](#34876)) * Remove steps title from scrubber ([sebmarkbage](https://github.com/sebmarkbage) in [#34878](#34878)) * Include some sub-pixel precision in rects ([sebmarkbage](https://github.com/sebmarkbage) in [#34873](#34873)) * Don't pluralize if already plural ([sebmarkbage](https://github.com/sebmarkbage) in [#34870](#34870)) * Don't try to load anonymous or empty urls ([sebmarkbage](https://github.com/sebmarkbage) in [#34869](#34869)) * Add inspection button to Suspense tab ([sebmarkbage](https://github.com/sebmarkbage) in [#34867](#34867)) * Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage) in [#34860](#34860)) * Don't highlight on timeline ([sebmarkbage](https://github.com/sebmarkbage) in [#34861](#34861)) * The bridge event types should only be defined in one direction ([sebmarkbage](https://github.com/sebmarkbage) in [#34859](#34859)) * Attempt at a better "unique suspender" text ([sebmarkbage](https://github.com/sebmarkbage) in [#34854](#34854)) * Track whether a boundary is currently suspended and make transparent ([sebmarkbage](https://github.com/sebmarkbage) in [#34853](#34853)) * Don't hide overflow rectangles ([sebmarkbage](https://github.com/sebmarkbage) in [#34852](#34852)) * Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in [#34851](#34851)) * Don't measure fallbacks when suspended ([sebmarkbage](https://github.com/sebmarkbage) in [#34850](#34850)) * Filter out built-in stack frames ([sebmarkbage](https://github.com/sebmarkbage) in [#34828](#34828)) * Exclude Suspense boundaries in hidden Activity ([eps1lon](https://github.com/eps1lon) in [#34756](#34756)) * Group consecutive suspended by rows by the same name ([sebmarkbage](https://github.com/sebmarkbage) in [#34830](#34830)) * Preserve the original index when sorting suspended by ([sebmarkbage](https://github.com/sebmarkbage) in [#34829](#34829)) * Don't show the root as being non-compliant ([sebmarkbage](https://github.com/sebmarkbage) in [#34827](#34827)) * Ignore suspense boundaries, without visual representation, in the timeline ([sebmarkbage](https://github.com/sebmarkbage) in [#34824](#34824)) * Explicitly say which id to scroll to and only once ([sebmarkbage](https://github.com/sebmarkbage) in [#34823](#34823)) * devtools: fix ellipsis truncation for key values ([sophiebits](https://github.com/sophiebits) in [#34796](#34796)) * fix(devtools): remove duplicated "Display density" field in General settings ([Anatole-Godard](https://github.com/Anatole-Godard) in [#34792](#34792)) * Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in [#34754](#34754)) * Release `<ViewTransition />` to Canary ([eps1lon](https://github.com/eps1lon) in [#34712](#34712))
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 24, 2025
Full list of changes: * Text layout fixes for stack traces with badges ([eps1lon](https://github.com/eps1lon) in [facebook#34925](facebook#34925)) * chore: read from build/COMMIT_SHA fle as fallback for commit hash ([hoxyq](https://github.com/hoxyq) in [facebook#34915](facebook#34915)) * fix: dont ship source maps for css in prod builds ([hoxyq](https://github.com/hoxyq) in [facebook#34913](facebook#34913)) * Lower case "rsc stream" debug info ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34921](facebook#34921)) * BuiltInCallSite should have padding-left ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34922](facebook#34922)) * Show the Suspense boundary name in the rect if there's no overlap ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34918](facebook#34918)) * Don't attach filtered IO to grandparent Suspense ([eps1lon](https://github.com/eps1lon) in [facebook#34916](facebook#34916)) * Infer name from stack if it's the generic "lazy" name ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34907](facebook#34907)) * Use same Suspense naming heuristics when reconnecting ([eps1lon](https://github.com/eps1lon) in [facebook#34898](facebook#34898)) * Assign a different color and label based on environment ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34893](facebook#34893)) * Compute environment names for the timeline ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34892](facebook#34892)) * Don't highlight the root rect if no roots has unique suspenders ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34885](facebook#34885)) * Highlight the rect when the corresponding timeline bean is hovered ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34881](facebook#34881)) * Repeat the "name" if there's no short description in groups ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34894](facebook#34894)) * Tweak the rects design and create multi-environment color scheme ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34880](facebook#34880)) * Adjust the rects size by one pixel smaller ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34876](facebook#34876)) * Remove steps title from scrubber ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34878](facebook#34878)) * Include some sub-pixel precision in rects ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34873](facebook#34873)) * Don't pluralize if already plural ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34870](facebook#34870)) * Don't try to load anonymous or empty urls ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34869](facebook#34869)) * Add inspection button to Suspense tab ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34867](facebook#34867)) * Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34860](facebook#34860)) * Don't highlight on timeline ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34861](facebook#34861)) * The bridge event types should only be defined in one direction ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34859](facebook#34859)) * Attempt at a better "unique suspender" text ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34854](facebook#34854)) * Track whether a boundary is currently suspended and make transparent ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34853](facebook#34853)) * Don't hide overflow rectangles ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34852](facebook#34852)) * Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34851](facebook#34851)) * Don't measure fallbacks when suspended ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34850](facebook#34850)) * Filter out built-in stack frames ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34828](facebook#34828)) * Exclude Suspense boundaries in hidden Activity ([eps1lon](https://github.com/eps1lon) in [facebook#34756](facebook#34756)) * Group consecutive suspended by rows by the same name ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34830](facebook#34830)) * Preserve the original index when sorting suspended by ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34829](facebook#34829)) * Don't show the root as being non-compliant ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34827](facebook#34827)) * Ignore suspense boundaries, without visual representation, in the timeline ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34824](facebook#34824)) * Explicitly say which id to scroll to and only once ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34823](facebook#34823)) * devtools: fix ellipsis truncation for key values ([sophiebits](https://github.com/sophiebits) in [facebook#34796](facebook#34796)) * fix(devtools): remove duplicated "Display density" field in General settings ([Anatole-Godard](https://github.com/Anatole-Godard) in [facebook#34792](facebook#34792)) * Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in [facebook#34754](facebook#34754)) * Release `<ViewTransition />` to Canary ([eps1lon](https://github.com/eps1lon) in [facebook#34712](facebook#34712)) DiffTrain build for [3cde211](facebook@3cde211)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 24, 2025
Full list of changes: * Text layout fixes for stack traces with badges ([eps1lon](https://github.com/eps1lon) in [facebook#34925](facebook#34925)) * chore: read from build/COMMIT_SHA fle as fallback for commit hash ([hoxyq](https://github.com/hoxyq) in [facebook#34915](facebook#34915)) * fix: dont ship source maps for css in prod builds ([hoxyq](https://github.com/hoxyq) in [facebook#34913](facebook#34913)) * Lower case "rsc stream" debug info ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34921](facebook#34921)) * BuiltInCallSite should have padding-left ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34922](facebook#34922)) * Show the Suspense boundary name in the rect if there's no overlap ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34918](facebook#34918)) * Don't attach filtered IO to grandparent Suspense ([eps1lon](https://github.com/eps1lon) in [facebook#34916](facebook#34916)) * Infer name from stack if it's the generic "lazy" name ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34907](facebook#34907)) * Use same Suspense naming heuristics when reconnecting ([eps1lon](https://github.com/eps1lon) in [facebook#34898](facebook#34898)) * Assign a different color and label based on environment ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34893](facebook#34893)) * Compute environment names for the timeline ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34892](facebook#34892)) * Don't highlight the root rect if no roots has unique suspenders ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34885](facebook#34885)) * Highlight the rect when the corresponding timeline bean is hovered ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34881](facebook#34881)) * Repeat the "name" if there's no short description in groups ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34894](facebook#34894)) * Tweak the rects design and create multi-environment color scheme ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34880](facebook#34880)) * Adjust the rects size by one pixel smaller ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34876](facebook#34876)) * Remove steps title from scrubber ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34878](facebook#34878)) * Include some sub-pixel precision in rects ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34873](facebook#34873)) * Don't pluralize if already plural ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34870](facebook#34870)) * Don't try to load anonymous or empty urls ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34869](facebook#34869)) * Add inspection button to Suspense tab ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34867](facebook#34867)) * Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34860](facebook#34860)) * Don't highlight on timeline ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34861](facebook#34861)) * The bridge event types should only be defined in one direction ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34859](facebook#34859)) * Attempt at a better "unique suspender" text ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34854](facebook#34854)) * Track whether a boundary is currently suspended and make transparent ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34853](facebook#34853)) * Don't hide overflow rectangles ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34852](facebook#34852)) * Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34851](facebook#34851)) * Don't measure fallbacks when suspended ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34850](facebook#34850)) * Filter out built-in stack frames ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34828](facebook#34828)) * Exclude Suspense boundaries in hidden Activity ([eps1lon](https://github.com/eps1lon) in [facebook#34756](facebook#34756)) * Group consecutive suspended by rows by the same name ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34830](facebook#34830)) * Preserve the original index when sorting suspended by ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34829](facebook#34829)) * Don't show the root as being non-compliant ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34827](facebook#34827)) * Ignore suspense boundaries, without visual representation, in the timeline ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34824](facebook#34824)) * Explicitly say which id to scroll to and only once ([sebmarkbage](https://github.com/sebmarkbage) in [facebook#34823](facebook#34823)) * devtools: fix ellipsis truncation for key values ([sophiebits](https://github.com/sophiebits) in [facebook#34796](facebook#34796)) * fix(devtools): remove duplicated "Display density" field in General settings ([Anatole-Godard](https://github.com/Anatole-Godard) in [facebook#34792](facebook#34792)) * Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in [facebook#34754](facebook#34754)) * Release `<ViewTransition />` to Canary ([eps1lon](https://github.com/eps1lon) in [facebook#34712](facebook#34712)) DiffTrain build for [3cde211](facebook@3cde211)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including Suspense in hidden Activity can be confusing since that likely ends up to overlapping rects (e.g. when each tab content is in an Activity or when previous "pages" are kept in Activity for a better backwards-forwards cache.
We now differentiate between Offscreen used by Suspense and Offscreen used by Activity. Activity-Offscreen will just unmount all nodes. Suspense-Offscreen will stay as-is and unmount nodes except Suspense nodes in the Suspense tree.