Skip to content

Conversation

eai04191
Copy link

@eai04191 eai04191 commented Oct 9, 2025

Summary

Fixed an issue where the TypeScript type inference for configuration keys was string in the flat config of eslint-plugin-react-hooks.

How did you test this change?

Regardless of this change, the build of eprh does not succeed in my environment, so I have not tested it.

Running: mkdir -p ./compiler/packages/babel-plugin-react-compiler/dist && echo "module.exports = require('../src/index.ts');" > ./compiler/packages/babel-plugin-react-compiler/dist/index.js
 BUILDING  eslint-plugin-react-hooks.development.js (node_dev)

@rollup/plugin-typescript TS7016: Could not find a declaration file for module '@babel/code-frame'. '/Users/eai/ghq/github.com/facebook/react/node_modules/@babel/code-frame/lib/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/babel__code-frame` if it exists or add a new declaration (.d.ts) file containing `declare module '@babel/code-frame';`

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

in yarn build

@meta-cla meta-cla bot added the CLA Signed label Oct 9, 2025
@react-sizebot
Copy link

Comparing: 4b3e662...3404830

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 604.98 kB 604.98 kB = 107.14 kB 107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.95 kB 663.95 kB = 117.03 kB 117.03 kB
facebook-www/ReactDOM-prod.classic.js = 687.81 kB 687.81 kB = 121.07 kB 121.07 kB
facebook-www/ReactDOM-prod.modern.js = 678.24 kB 678.24 kB = 119.42 kB 119.42 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 3404830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: [email protected] Type 'ReactHooksFlatConfig | undefined' is not assignable to type 'InfiniteArray<ConfigWithExtends>'

2 participants