[DevTools] Adjust aspect ratio of "x ray" viewport to the same as the window#35014
Closed
sebmarkbage wants to merge 1 commit intofacebook:mainfrom
Closed
[DevTools] Adjust aspect ratio of "x ray" viewport to the same as the window#35014sebmarkbage wants to merge 1 commit intofacebook:mainfrom
sebmarkbage wants to merge 1 commit intofacebook:mainfrom
Conversation
github-actions
bot
added
the
React Core Team
sebmarkbage
force-pushed
the
aspectratio
branch
from
0392aee to
ea80e1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shrinks the viewport of the suspense rects to match the aspect ratio of the real viewport. The idea is that this would make it clearer that it's a mirrored view and when auto scrolling it would line up more accurately for things that are within the viewport.
I thought I'd like it but I don't think I do actually. I don't think it ended up adding anything since the aspect ratio when you anchor the devtools end up some what close enough anyway. You're just losing screen real estate for no reason. But submitting for your consideration.