config: allow 'extra' in root of single-project config files #5030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable to me. Let me know when this PR is ready to review. Thanks for working on this! |
The 'extra' property was previously only declared for the projects in a multi-project config file. Since unknown fields are considered an error when parsing single-project config files, this made it impossible to include arbitrary metadata via a package.json config or a relay.config.json file. Allow 'extra' at the root of a single-project config file to better-match the structure of projects in a multi-project config. fixes facebook#5029
sjbarag
force-pushed
the
allow-extra-in-single-project-configs
branch
from
86fc7d7 to
2dd36ca
Compare
|
@captbaritone ready for review! Sorry, forgot to drive |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this in D77896280. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'extra' property was previously only declared for the projects in a multi-project config file. Since unknown fields are considered an error when parsing single-project config files, this made it impossible to include arbitrary metadata via a package.json config or a relay.config.json file. Allow 'extra' at the root of a single-project config file to better-match the structure of projects in a multi-project config.
fixes #5029