Add test_follower option to crash test#13282
Draft
archang19 wants to merge 3 commits intofacebook:mainfrom
Draft
Add test_follower option to crash test#13282archang19 wants to merge 3 commits intofacebook:mainfrom
archang19 wants to merge 3 commits intofacebook:mainfrom
Conversation
archang19
force-pushed
the
test-follower-crash-option
branch
2 times, most recently
from
2ca0fcd to
15a7e9e
Compare
archang19
changed the title
archang19
force-pushed
the
test-follower-crash-option
branch
from
4a5d56a to
9b2794c
Compare
archang19
force-pushed
the
test-follower-crash-option
branch
from
9b2794c to
2e6d65a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context: We want to enable secondaries and followers to be tested in crash tests. #13281 added the ability to verify the values returned by
Get()requests to secondaries against theExpectedState. Although there was atest_secondaryflag, none of the old secondary verification code was actually being executed in the recurring crash test suites. There also was no flag to enable even the creation of a follower instance.First, this PR adds a new flag that lets us open a follower database inside the crash test. It is modeled after the code/flags for secondaries. The follower itself presumably has some
assertstatements inside its implementation, so this would not be completely useless on its own.Test Plan