-
Notifications
You must be signed in to change notification settings - Fork 328
[babel-plugin] polyfill all nonstandard properties in 'legacy-expand-… #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
workflow: benchmarks/perfComparison of performance test results, measured in operations per second. Larger is better.
|
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
packages/@stylexjs/babel-plugin/__tests__/legacy/stylex-transform-legacy-shorthands-test.js
Outdated
Show resolved
Hide resolved
packages/@stylexjs/babel-plugin/__tests__/legacy/stylex-transform-legacy-shorthands-test.js
Show resolved
Hide resolved
packages/@stylexjs/babel-plugin/__tests__/legacy/stylex-transform-legacy-shorthands-test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamping to unblock. This will be faster than blocking on codemodding. And all these tests for legacy features will get deleted eventually
Most of the common rules |
Adding some missing polyfills for some of the more obscure nonstandard properties we use internally. Previously these would get translated to LTR/RTL, but we need to add mappings to standard logical properties.
Synced with the flag turned on and off internally, all screenshot tests passing. Added some tests to to document the expected behaviour. These tests are a bit verbose and the structure hard to navigate, and I'm hoping we can clean them up and reorganize them soon after we ship logical styles.
transform-legacy-polyfills-test
contains tests for all nonstandard propertieslegacy-expand-shorthands
stylex-transform-legacy-shorthands-test.js
contains all expanded shorthandsenableLogicalStylesPolyfill: false
tests