Skip to content

Conversation

daxpedda
Copy link
Contributor

Currently users would have to depend manually on curve25519-dalek to enable Serde.

This seems to have been lost back in #28, I suspect because enabling crate features on optional dependencies with ? wasn't available back then.

Analogous to facebook/opaque-ke#375.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2025
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevinlewi kevinlewi merged commit 23aa781 into facebook:main Apr 28, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants