Align Ristretto255::random_scalar()
with specification
#142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification states:
While the
elliptic-curve
implementation did just that, thecurve25519-dalek
did not, instead it simply reduced to a correct scalar. The specification proposes an alternative to rejection sampling, however for Ristretto255 it requires reducing from 48 bytes, thecurve25519-dalek
implementation was reducing from 64 bytes.With the help of
FromOkm
we might want to consider switching to a constant-time implementation instead. However I'm awaiting feedback on this errata: https://www.rfc-editor.org/errata/eid8393.