Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group trait experiment #49

Closed
wants to merge 3 commits into from
Closed

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Dec 27, 2021

This is an initial experiment on how to completely transition away from providing any specific implementation of Group in the voprf crate, but rely on traits from elliptic-curve exclusively.

Which is impossible at the moment, but this is a first step into the right direction. Missing steps would be:

It introduces two types:

  • Voprf trait, which extracts the SUITE_ID from Group. It also binds the SUITE_ID to a corresponding hash, which wasn't done before.
  • Ristretto255, which implements Group, as it is unlikely that curve25519-dalek will implement the traits we need anytime soon.

Other changes:

  • Re-ordered Group.
  • Removed Group::zeroize() and used trait bound instead.
  • Added HashMarker as a trait bound to H.
  • Added Voprf as a trait bound to G.
  • Changed SUITE_ID to u16 because it can't be bigger anyway.

See discussions in facebook/opaque-ke#254 and facebook/opaque-ke#250.
Builds on top of #48.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants