Move to ZeroizeOnDrop
#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
daxpedda
force-pushed
the
zeroize
branch
2 times, most recently
from
5775e89 to
4f780ba
Compare
|
CI somehow isn't running? |
|
Very interesting, somehow I managed to make CI not run after a re-base ... anyway, works now. |
|
I discovered RustCrypto/utils#719 while doing this. A bug I introduced myself! So waiting for this next. |
Merged
|
Addressed the failing build in main by updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #56.
Still waits for a new release ofderive-where.Moving to
ZeroizeOnDropgives us what we want without allowing the user to break all invariants we provide.