Skip to content

Conversation

@darekbx
Copy link

@darekbx darekbx commented Oct 16, 2024

Added documentation detailing how to build the Yoga library for Java/Android.

@vercel
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:43am

@facebook-github-bot facebook-github-bot added CLA Signed Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 16, 2024
@NickGerleman
Copy link
Contributor

Writing instructions for how to patch the current build logic to build JNI part of library for macOS doesn’t seem very durable.

For Android we rely on Android Gradle Plugin’s NDK/CMake integration, and just distribute binaries.

If we wanted to support building Java locally more gracefully, we probably want a way to have Gradle without Android bits hook CMake, or potentially just go the route of Gradle C++ libraries more venally. https://docs.gradle.org/current/userguide/cpp_library_plugin.html

Separately, out of curiosity, what warnings as errors did you run into? We have a good number of different builds with high warning level in OSS CI, and internally at Meta, so I’m curious what gap we still have.

@lunaleaps
Copy link

Can't speak on the actual build instructions, but wondering why the README wasn't used for these instructions.

@darekbx
Copy link
Author

darekbx commented Oct 18, 2024

@NickGerleman We got some errors and warnings while building Yoga for Java on MacOs with Apple CPU. We are creating custom implementation of Flexbox layout for Android Compose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants