-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Migrate YogaProps to Kotlin
#1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D79897771. |
1 similar comment
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D79897771. |
|
This is breaking a bunch of stuff internally because is made in a breaking manner. Here an example of what breaks. Can you update this to use val so that it doesn't break with Litho? |
cortinico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment
|
Thanks! Could you please take a second pass? I updated the possible getters to vals in 19b96f5. |
|
Landing this will be a bit more complicated that I thought. Leave it to me, I'll take care of it (we might have to resort to land the original version) |
Migrate com.facebook.yoga.YogaProps to Kotlin.
Test plan:
RN
Yoga