Skip to content

Fix missing enum values in switch statements (xplat/js) #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing enum values in switch statements (xplat/js) #1862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions yoga/style/StyleLength.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,14 @@ class StyleLength {
}

constexpr FloatOptional resolve(float referenceLength) {
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wswitch-enum"
#endif
switch (unit_) {
#ifdef __clang__
#pragma clang diagnostic pop
#endif
case Unit::Point:
return value_;
case Unit::Percent:
Expand Down
7 changes: 7 additions & 0 deletions yoga/style/StyleSizeLength.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,14 @@ class StyleSizeLength {
}

constexpr FloatOptional resolve(float referenceLength) {
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wswitch-enum"
#endif
switch (unit_) {
#ifdef __clang__
#pragma clang diagnostic pop
#endif
case Unit::Point:
return value_;
case Unit::Percent:
Expand Down
Loading