Skip to content

Address -Wswitch-default warnings #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Address -Wswitch-default warnings #1864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions yoga/algorithm/FlexDirection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ inline PhysicalEdge flexStartEdge(FlexDirection flexDirection) {
return PhysicalEdge::Left;
case FlexDirection::RowReverse:
return PhysicalEdge::Right;
default:
fatalWithMessage("Invalid FlexDirection");
}

fatalWithMessage("Invalid FlexDirection");
}

inline PhysicalEdge flexEndEdge(FlexDirection flexDirection) {
Expand All @@ -75,9 +75,9 @@ inline PhysicalEdge flexEndEdge(FlexDirection flexDirection) {
return PhysicalEdge::Right;
case FlexDirection::RowReverse:
return PhysicalEdge::Left;
default:
fatalWithMessage("Invalid FlexDirection");
}

fatalWithMessage("Invalid FlexDirection");
}

inline PhysicalEdge inlineStartEdge(
Expand Down Expand Up @@ -112,9 +112,9 @@ inline Dimension dimension(FlexDirection flexDirection) {
return Dimension::Width;
case FlexDirection::RowReverse:
return Dimension::Width;
default:
fatalWithMessage("Invalid FlexDirection");
}

fatalWithMessage("Invalid FlexDirection");
}

} // namespace facebook::yoga
8 changes: 4 additions & 4 deletions yoga/algorithm/SizingMode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ inline MeasureMode measureMode(SizingMode mode) {
return MeasureMode::Undefined;
case SizingMode::FitContent:
return MeasureMode::AtMost;
default:
fatalWithMessage("Invalid SizingMode");
}

fatalWithMessage("Invalid SizingMode");
}

inline SizingMode sizingMode(MeasureMode mode) {
Expand All @@ -65,9 +65,9 @@ inline SizingMode sizingMode(MeasureMode mode) {
return SizingMode::MaxContent;
case MeasureMode::AtMost:
return SizingMode::FitContent;
default:
fatalWithMessage("Invalid MeasureMode");
}

fatalWithMessage("Invalid MeasureMode");
}

} // namespace facebook::yoga
16 changes: 8 additions & 8 deletions yoga/style/Style.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,9 +673,9 @@ class YG_EXPORT Style {
return computeRightEdge(position_, direction);
case PhysicalEdge::Bottom:
return computeBottomEdge(position_);
default:
fatalWithMessage("Invalid physical edge");
}

fatalWithMessage("Invalid physical edge");
}

Style::Length computeMargin(PhysicalEdge edge, Direction direction) const {
Expand All @@ -688,9 +688,9 @@ class YG_EXPORT Style {
return computeRightEdge(margin_, direction);
case PhysicalEdge::Bottom:
return computeBottomEdge(margin_);
default:
fatalWithMessage("Invalid physical edge");
}

fatalWithMessage("Invalid physical edge");
}

Style::Length computePadding(PhysicalEdge edge, Direction direction) const {
Expand All @@ -703,9 +703,9 @@ class YG_EXPORT Style {
return computeRightEdge(padding_, direction);
case PhysicalEdge::Bottom:
return computeBottomEdge(padding_);
default:
fatalWithMessage("Invalid physical edge");
}

fatalWithMessage("Invalid physical edge");
}

Style::Length computeBorder(PhysicalEdge edge, Direction direction) const {
Expand All @@ -718,9 +718,9 @@ class YG_EXPORT Style {
return computeRightEdge(border_, direction);
case PhysicalEdge::Bottom:
return computeBottomEdge(border_);
default:
fatalWithMessage("Invalid physical edge");
}

fatalWithMessage("Invalid physical edge");
}

Direction direction_ : bitCount<Direction>() = Direction::Inherit;
Expand Down
Loading