This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Combine icon & kind in Outline View into a unified styleable property #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
changed the title
|
@damieng updated the pull request - view changes |
|
@damieng updated the pull request - view changes |
|
@damieng updated the pull request - view changes |
|
@damieng updated the pull request - view changes |
|
this looks fine to me! what do you think @hansonw? |
|
yay! When are these icons going to be in Atom? |
|
They are in on master now.
atom/atom#14657
Now I can see them in place I'm going to suggest a couple more tweaks to
them.
…On Fri, Jun 9, 2017 at 11:25 AM Hanson Wang ***@***.***> wrote:
yay! When are these icons going to be in Atom?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1182 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHQp2VVRCaauIYx256duvVhrEVXBM-gks5sCY4CgaJpZM4NzTSW>
.
|
|
@ljw1004 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@damieng should these be named "Atomicons" rather than "OcticonsPrivate"? Or at least that's what the PR suggests: atom/atom#14657 |
|
Yeah I can rename those and rebase. |
|
@ebluestein has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
What's the state on this? I thought it had got merged... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there is a .icon property which maps to Atom$Icons which doesn't have the icons we really want as well as a .kind property for theming I added.
This unifies the two - my new LSP-compatible icons are mapped to type-x where x is the kind property from LSP.
Should be no migration problems now as this preserves existing icon behavior for nuclide/those that used it and my usage from atom-languageclient of the now-removed kind had no impact yet.