Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

added show on cursor over for datatip #1626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added show on cursor over for datatip #1626

wants to merge 1 commit into from

Conversation

udnaan
Copy link

@udnaan udnaan commented Oct 3, 2018

This pull request adds datatip on cursor while using keyboard. The setting can be turned on by going into settings.

This is the same pull request

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pelmers has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kcaze
Copy link

kcaze commented Oct 4, 2018

This doesn't seem right. I put some logging in _startFetching() and confirmed that if this is turned on, it'll try to fetch datatips on every single keystroke.

This feels like it should at least do _startFetchingDebounce() instead of _startFetching()?

@facebook-github-bot
Copy link

@udnaan has updated the pull request. Re-import the pull request

@udnaan
Copy link
Author

udnaan commented Oct 4, 2018

I switched to startFetchingDebounce but in a local test, this doesn't do what it is suppose to do. I will have to stick with the startFetching unless someone has any insights.

@udnaan
Copy link
Author

udnaan commented Oct 10, 2018

Any timeframe on when this will be in or is there something else needs to be done to the PR?

@k-ode
Copy link

k-ode commented Nov 7, 2018

I would also like this and would be happy to test and debug any issues that needs to be fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants