Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

nightly-2023-12-30 #1272

Merged
merged 1 commit into from
Jul 16, 2024
Merged

nightly-2023-12-30 #1272

merged 1 commit into from
Jul 16, 2024

Conversation

hermanventer
Copy link
Contributor

Description

Update toolchain to nightly-2023-12-30 and deal with changes. Also update dependencies.

Type of change

  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

./validate.sh vcpkg

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2024
@hermanventer hermanventer merged commit 41887ea into main Jul 16, 2024
7 checks passed
@hermanventer hermanventer deleted the new_nightly branch July 16, 2024 17:25
@gal1ium
Copy link

gal1ium commented Jul 25, 2024

Hi! I found that, in standard_contracts/src/foreign_contracts.rs, some std contracts are not updated according to the nightly-2023-12-30's std. For example, in

cap in nightly-2023-12-30 is an Enum Cap, not a usize, which leads to some wrong analysis results.
May I ask if the only way to fix such issues is to compare the current foreign_contracts with the std source one by one?

@hermanventer
Copy link
Contributor Author

Sadly, yes. At some point it would be great if we can build MIRAI in such a way that the full sources of the standard libraries are available to MIRAI at runtime. Perhaps this is feasible now, but when I had a lot more time to work on this, it was not possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants