Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for building on linux #402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add CI for building on linux #402

wants to merge 1 commit into from

Conversation

c-p-i-o
Copy link
Contributor

@c-p-i-o c-p-i-o commented Dec 12, 2024

  1. Update libuv version
  2. Install openssl 1.1
    Gloo is currently pinned to openssl 1.1.
    See: gloo/test/CMakeLists.txt
    It has:
    find_package(OpenSSL 1.1 REQUIRED EXACT)
  3. Build with c++17 to resolve libuv errors.
  4. Always install libssl-dev
  5. Add LD_LIBRARY_PATH for runners
  6. SSL max limit is 512M - 1

Also, make a small change to one of the tests.
SSL max limit is 512M - 1 byte
broadcast test fails at 512M, passes with 1 less byte.
TODO: comment where this limit is coming from.

.github/workflows/build_linux.yaml Outdated Show resolved Hide resolved
.github/workflows/build_linux.yaml Outdated Show resolved Hide resolved
@c-p-i-o c-p-i-o force-pushed the cpio/linux_ci branch 12 times, most recently from a25c7a4 to d31256d Compare December 13, 2024 21:07
@c-p-i-o c-p-i-o force-pushed the cpio/linux_ci branch 8 times, most recently from 752d54c to a31baec Compare December 30, 2024 18:41
@c-p-i-o c-p-i-o force-pushed the cpio/linux_ci branch 2 times, most recently from 7cb0c59 to d4b17ab Compare January 29, 2025 21:25
1. Update libuv version
2. Install openssl 1.1
Gloo is currently pinned to openssl 1.1.
See: gloo/test/CMakeLists.txt
It has:
find_package(OpenSSL 1.1 REQUIRED EXACT)
3. Build with c++17 to resolve libuv errors.
4. Always install libssl-dev
5. Add LD_LIBRARY_PATH for runners
6.  SSL max limit is 512M - 1

Also, make a small change to one of the tests.
SSL max limit is 512M - 1 byte
broadcast test fails at 512M, passes with 1 less byte.
TODO: comment where this limit is coming from.
@facebook-github-bot
Copy link

@c-p-i-o has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@c-p-i-o c-p-i-o self-assigned this Jan 29, 2025
@c-p-i-o c-p-i-o marked this pull request as ready for review January 29, 2025 21:29
@c-p-i-o c-p-i-o requested a review from d4l3k January 29, 2025 21:29
@c-p-i-o c-p-i-o requested review from wconstab and fduwjj January 29, 2025 21:29
@facebook-github-bot
Copy link

@c-p-i-o has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants