-
Notifications
You must be signed in to change notification settings - Fork 78
[Feature] Expose additional arguments for Wandb #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, sorry for taking so long. Only one point about bc-breaking
# WandbLogger includes: offline, save_dir, project, video_fps | ||
# wandb.init includes: entity, tags, notes, etc. | ||
wandb_extra_kwargs: | ||
project: "benchmarl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the only problem is that this is backwards compatibility breaking and I would like to avoid that.
What about we keep the project name out and have wandb_extra_kwargs: {}
?
Then is someone provides the project
in wandb_extra_kwargs and it is different from project_name we tell them through an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get you, sounds good.
What does this PR do?
It exposes
wandb_extra_kwargs
in the experiment config to pass additional arguments to bothWandbLogger
andwandb.init
.To discuss
ExperimentConfig
, e.g. using a field like:wandb
as a default logger (base_experiment
) really ideal?Happy to iterate.